Skip to content

chore(dev): Compose stack with PostgreSQL 17 and SeaweedFS, database roles and Makefile - #23

Merged
omercnet merged 2 commits into
mainfrom
replay/13-dev
Nov 21, 2026
Merged

omercnet merged 2 commits into
mainfrom
replay/13-dev

Conversation

@omercnet

@omercnet omercnet commented Nov 21, 2026 •

Copy link
Copy Markdown
Contributor

What changed

The development stack: compose.yaml (PostgreSQL 17 and SeaweedFS, database roles and extensions created on an empty volume), .env.example, the db/init scripts and a first Makefile (db-up, down, db-down, down-volumes, test; the development token secret is generated per checkout, never a fixed default). CI gains two jobs: Compose config (validates the Compose file, hosted runner) and Integration tests (RunsOn: starts the stack with make db-up, builds, runs the integration project, always tears down; there are no integration tests yet, so it exits with success). AGENTS.md lists the new commands, states the CI jobs and the fake-per-port rule as it is today, and the Docker safety rules now apply without condition.

Rebased onto main (the slice below it has merged); auto-merge is on.

Why

Integration tests in later slices need a real database and file store; the stack and the job are reviewed on their own first.

How it was verified

In the generated tree, exactly what the jobs run: docker compose -p grimoire config --quiet (with .env copied from .env.example); make db-up (both services healthy in 5.5 s with the images already present); bun run build; bun run test:integration; make down-volumes (no containers or volumes left). Then bun install --frozen-lockfile, lint, typecheck, build, unit, tool tests, licence, gitleaks, actionlint, zizmor: all exit 0.

Visuals

Job times from this pull request's own CI run are in the first comment.

Not here yet

The integration tests themselves, the image and stack job, and the exit tests.

Checklist

  • Tests added or updated, or not applicable
  • No secrets or credentials committed
  • Docs updated, or not applicable

@shuni-bot

shuni-bot Bot commented Nov 21, 2026 •

Copy link
Copy Markdown

🐕 Shuni Review

No new issues found.

🤖 Model: claude-opus-5.5 · Effort: medium


Review scope: Partial incremental re-review

Reviewed new changes (2)
  • AGENTS.md
  • compose.yaml
Previously reviewed and unchanged: 6 files.

🐕 Review complete — View session on Shuni Portal 🐾

🤖 Model: claude-opus-5.5 · Effort: medium

@baz-reviewer

baz-reviewer Bot commented Nov 21, 2026 •

Copy link
Copy Markdown

Review this PR on Baz

Baz Summary

Provide a PostgreSQL 17 and SeaweedFS development stack with initialized database roles, extensions, credentials, and persistent volumes through Compose and Make targets. Add CI jobs to validate the Compose configuration and run integration tests against the stack, with documentation and teardown guidance.

Topics

TopicDetails
Integration CI Validate the Compose configuration and run integration builds and tests against the development services in CI, while documenting commands, fake-port expectations, and Docker safety rules.
Modified files (2)
  • .github/workflows/ci.yml
  • AGENTS.md
Latest Contributors(1)
UserCommitDate
omercnetfix(dev): the database...November 21, 2026
Development stack Provision PostgreSQL and SeaweedFS locally with health checks, persistent storage, role and extension initialization, environment defaults, and safe Makefile lifecycle commands.
Modified files (6)
  • .env.example
  • Makefile
  • compose.yaml
  • db/init/01-roles.sh
  • db/init/02-extensions.sql
  • db/init/roles.psql
Latest Contributors(1)
UserCommitDate
omercnetfix(dev): the database...November 21, 2026


Merger  Activate to get a short verdict whether this PR is good to go or not

Skills  Activate Skill Maintainer to keep your skills up to date

Planner  This PR would have been improved with Baz Planner - Try it now

Comment thread .env.example Resolved
Comment thread .env.example Resolved
Comment thread Makefile Resolved
@omercnet

Copy link
Copy Markdown
Contributor Author

Job times (seconds) from this pull request's CI run (first run of the two new jobs; image pulls were cold on the RunsOn machine).

Job Runner Queued to start Duration
Compose config hosted 2 3
Integration tests RunsOn 4 cpu 19 31
Static checks RunsOn 4 cpu 18 14
Unit tests RunsOn 4 cpu 18 20
Licence check RunsOn 4 cpu 20 12
Secret Scan hosted 2 11
Workflow Policy hosted 2 11
CI Required hosted 1 3

Docker was available on the RunsOn machine, both images pulled without rate limiting, and the database and file store became healthy.

@shuni-bot shuni-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐕 Shuni review: 3 inline findings. Every changed file in this pull request was reviewed.

The full review summary is in Shuni's sticky review comment on this pull request.

Comment thread compose.yaml Resolved
Comment thread .github/workflows/ci.yml Resolved
Comment thread Makefile Resolved
Base automatically changed from replay/12-log to main November 21, 2026 12:59

@shuni-bot shuni-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐕 Shuni review: 1 inline finding. Every changed file in this pull request was reviewed.

The full review summary is in Shuni's sticky review comment on this pull request.

Comment thread AGENTS.md Resolved

@shuni-bot shuni-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐕 Shuni review: no new findings. Every changed file in this pull request was reviewed.

The full review summary is in Shuni's sticky review comment on this pull request.

@shuni-bot shuni-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐕 Shuni review: no new findings. Every changed file in this pull request was reviewed.

The full review summary is in Shuni's sticky review comment on this pull request.

@omercnet
omercnet marked this pull request as draft November 21, 2026 13:10
auto-merge was automatically disabled November 21, 2026 13:10

Pull request was converted to draft

@omercnet
omercnet marked this pull request as ready for review November 21, 2026 13:10
@omercnet
omercnet enabled auto-merge (squash) November 21, 2026 13:10
@omercnet
omercnet merged commit 295937b into main Nov 21, 2026
14 checks passed
@omercnet
omercnet deleted the replay/13-dev branch November 21, 2026 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant